search

marko-js / marko

A declarative, HTML-based language that makes building web apps fun
https://markojs.com/
MIT License
13.35k stars 643 forks source link

Regression in valueless attributes #1228

Closed src-code closed 5 years ago

src-code commented 5 years ago

Marko Version: Starting with 4.14.8 or 4.14.9. Is still an issue as of 4.14.17

Details

Valueless attributes (for example, the AMP attribute <html ⚡ lang="en">) began receiving a numeric attribute name sometime after 4.14.7. Now the above tag is rendered as <html 0="⚡" lang="en"> which is incorrect, and is a regression.

Expected Behavior

Attributes should be rendered without modification.

Actual Behavior

Your Environment

Found on Node 8.12.x

DylanPiercey commented 5 years ago

Hey @src-code, so far I haven't been able to reproduce this issue myself (starting from a blank slate with the example you have above). Are you able to either add a failing test case to Marko or create a sample repo that you could share with us?

DylanPiercey commented 5 years ago

Going to close this one for now. If the issue is still persisting the latest version of Marko please recreate the issue and provide a reproducible example. If possible an example using a gist link on the try online (https://markojs.com/try-online/?gist=) is often simplest.