marko-js / marko

A declarative, HTML-based language that makes building web apps fun
https://markojs.com/
MIT License
13.42k stars 646 forks source link

refactor: misc refactoring for controllable input #2350

Closed DylanPiercey closed 3 weeks ago

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 9c60013154c3a325a5c2e68385b2d5781fbe1cb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------- | ----- | | @marko/translator-tags | Patch | | @marko/runtime-tags | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 61.89427% with 173 lines in your changes missing coverage. Please review.

Project coverage is 87.79%. Comparing base (7394cda) to head (9c60013). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/controllable.ts 56.38% 138 Missing and 2 partials :warning:
...ges/translator-tags/src/visitors/tag/native-tag.ts 55.76% 23 Missing :warning:
...es/runtime-tags/src/dom/resolve-cursor-position.ts 33.33% 4 Missing :warning:
packages/runtime-tags/src/html/attrs.ts 88.88% 2 Missing :warning:
packages/runtime-tags/src/html/dynamic-tag.ts 84.61% 1 Missing and 1 partial :warning:
packages/runtime-tags/src/dom.ts 50.00% 1 Missing :warning:
packages/runtime-tags/src/dom/queue.ts 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2350 +/- ## ========================================== - Coverage 87.97% 87.79% -0.18% ========================================== Files 343 343 Lines 37624 37580 -44 Branches 2357 2341 -16 ========================================== - Hits 33098 32995 -103 - Misses 4506 4564 +58 - Partials 20 21 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.