search

marko-js / markojs.com-legacy

Source code for markojs.com
http://markojs.com
MIT License
14 stars 13 forks source link

Fix google search URL filtering error #10

Closed adammcarth closed 8 years ago

adammcarth commented 8 years ago

I'm using El Capitan and the latest stable version of Chrome, and it seems like the current technique you're using to search the markojs.com website through google isn't working. I've added in a quick workaround: Google appends the site: markojs.com after the search query using a parameter called as_sitesearch. Looks like its now working as expected from my end :)

As a side note, I was unable to actually get the node_modules/marko/docs directory working to pull the documentation from as the README for this repo explained it. The docs directory doesn't seem to be there... did you stop shipping it with the Marko package? I just commented out checkDocs(); while I was testing though.

patrick-steele-idem commented 8 years ago

Hey @adammcarth, thanks for the PR! I'll take a look at publish a new version of the site ASAP.

Regarding the side note, newer versions of npm starting pruning .npmignore files even for projects that are npm installed directly from a Git repo. As a result, in order to generate the site locally you need to npm link both marko and marko-widgets into the website project. I'll try to make this more clear in the docs. However, I'm tempted to just not .npmignore the docs/ folders for both marko and marko-widgets since it probably doesn't hurt to include the set of docs in the published package.

patrick-steele-idem commented 8 years ago

Thanks again for the PR, @adammcarth. I have published a new version of the website with your fix to markojs.com. Please let us know if you find any other issues.

I also updated the marko package to include the docs/ directory (see https://github.com/marko-js/marko/commit/32d7205e421c8aa9336f2b6e2b45fcbd67a7ac83). You should have no issues running the website locally now after you update to the latest node modules.

adammcarth commented 8 years ago

Sweet, thanks for that @patrick-steele-idem. I don't think there's any harm having docs included with the base Marko package, so good call.