search

marko-js / markojs.com-legacy

Source code for markojs.com
http://markojs.com
MIT License
14 stars 13 forks source link

ES6 string template syntax #18

Closed KingMario closed 7 years ago

KingMario commented 7 years ago

I guess that the intention of the sample is to convert all contents inside the quotation marks upper case. Otherwise, <p>Hello ${data.name.toUpperCase()}</p> is more applicable. Then ES6 string template syntax should be used.

Or

whether the template is not compiled correctly? Should it be compiled this way:

"<p>" + escapeXml(("Hello " + data.name).toUpperCase()) + "</p>"
austinkelleher commented 7 years ago

Sorry for the late reply. Technically both methods are supported. I will go ahead and merge this for clarity.

austinkelleher commented 7 years ago

Also our website has been revamped. Check it out: http://markojs.com