marko-js / tags-api-preview

Preview the Marko 6 "Tags API" in Marko 5!
MIT License
22 stars 7 forks source link

feat: allow missing default attribute for let tag #22

Closed DylanPiercey closed 2 years ago

DylanPiercey commented 2 years ago

Description

The <let> tag was needlessly restricted to require a default attribute, so if you had <let/x/> it'd error instead of just initializing as undefined.

This PR updates it to no longer error in that case.

Checklist:

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 0d4e85c6c1f6e41550b123372da757a81e7a428a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------- | ----- | | @marko/tags-api-preview | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (0d4e85c) into main (c396076) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          62       62           
  Lines        1023     1023           
  Branches      329      329           
=======================================
  Hits          982      982           
  Misses         14       14           
  Partials       27       27           
Impacted Files Coverage Δ
src/components/let/translate.ts 97.50% <100.00%> (ø)
src/util/deep-freeze/transform.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c396076...0d4e85c. Read the comment docs.