marko-js / tags

Not quite core components.
MIT License
22 stars 11 forks source link

feat(context): use constructor instance as context id #27

Closed DylanPiercey closed 4 years ago

DylanPiercey commented 4 years ago

BREAKING CHANGE: This requires that the context provider is always sent to the browser and rendered in the browser

Scope

<context>

Description

Currently <context> uses the lasso-client id (shortened file name) as the id value for the context content in the lookup. This PR updates the context to use the component constructor instead.

Motivation and Context

The primary benefit of this is that is would fix support for hot swapping out the context provider via mechanisms like jests mock, HMR, etc.

Checklist: