search

marko-js / vite

A Marko plugin for Vite
MIT License
55 stars 8 forks source link

fix: revert #16 #20

Closed DylanPiercey closed 2 years ago

DylanPiercey commented 2 years ago

Description

Reverts #16 since it ultimately causes all assets to be injected before any html has been rendered.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #20 (d59420c) into main (20808df) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d59420c differs from pull request most recent head ab75b54. Consider uploading reports for the commit ab75b54 to get more accurate results

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files           6        6           
  Lines         344      344           
  Branches       89       89           
=======================================
  Hits          287      287           
  Misses         49       49           
  Partials        8        8
Impacted Files Coverage Δ
src/render-assets-transform.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20808df...ab75b54. Read the comment docs.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: