search

marko-js / vite

A Marko plugin for Vite
MIT License
54 stars 7 forks source link

fixes virtual dep resolution for dynamically imported inline styles #90

Closed jwise7 closed 9 months ago

jwise7 commented 9 months ago

Description

created a helper function to handle the slight differences between the ssr/dom virtual file resolution and the hydrate file resolution

Motivation and Context

Fixes an issue with a dynamically imported marko component's inline style. previously it would create a file name that wouldn't work (404)

Screenshots (if appropriate):

Checklist:

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: d002c0ca3fa206851bd4f48d4e3632a527069289

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c0beb37) 76.53% compared to head (d002c0c) 76.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 76.53% 76.75% +0.21% ========================================== Files 9 9 Lines 537 542 +5 Branches 120 121 +1 ========================================== + Hits 411 416 +5 Misses 81 81 Partials 45 45 ``` | [Files](https://app.codecov.io/gh/marko-js/vite/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js) | Coverage Δ | | |---|---|---| | [src/index.ts](https://app.codecov.io/gh/marko-js/vite/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL2luZGV4LnRz) | `74.78% <85.71%> (+0.36%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwise7 commented 9 months ago

not needed anymore