marko-js / vite

A Marko plugin for Vite
MIT License
54 stars 7 forks source link

test: change server type for vite 5 change #93

Closed sapphi-red closed 8 months ago

sapphi-red commented 8 months ago

Description

Make testPage function to accept http.Server | Http2SecureServer instead of http.Server.

Motivation and Context

This PR fixes the type incompatibility with Vite 5.

related: https://github.com/vitejs/vite/pull/14834

Screenshots (if appropriate):

Checklist:

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 282894784fb8171c2c7d4afe10c7ef4ae5ce3ea7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linux-foundation-easycla[bot] commented 8 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (978db3f) 76.53% compared to head (2828947) 76.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ======================================= Coverage 76.53% 76.53% ======================================= Files 9 9 Lines 537 537 Branches 120 120 ======================================= Hits 411 411 Misses 81 81 Partials 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.