feat: dynamic builds now use $global.buildName - Githubissues

marko-js / webpack

A loader for marko files and a plugin for universal bundling

MIT License

13 stars 4 forks source link

feat: dynamic builds now use $global.buildName #23

Closed DylanPiercey closed 4 years ago

DylanPiercey commented 4 years ago

BREAKING CHANGE: The getClientCompilerName API has been removed.

Description

This PR removes the somewhat clunky API around getClientCompilerName in favor of a simpler approach of always reading from $global.buildName.

Motivation and Context

The current API can be confusing since the function is actually inlined into the bundle which means none of its scope is available.

Checklist:

[x] I have updated/added documentation affected by my changes.
[ ] I have added tests to cover my changes.