marko-js / webpack

A loader for marko files and a plugin for universal bundling
MIT License
13 stars 4 forks source link

Snapshot fixes #50

Closed mlrawlings closed 3 years ago

mlrawlings commented 3 years ago

When pulling down the latest code, there were snapshot failures due to the inclusion of an absolute path for virtual dependencies and a new version of webpack being pulled in which slightly changed its runtime.

It seems that the npm:webpack@^5.0.0 does not respect the version in package-lock.json with the default install command (though it does with npm ci).

We may want to consider switching webpack5 to webpack and then add a webpack4 alias that is pinned to the current 4.x release as that's getting less updates, but this PR does not do that.