marko-js / webpack

A loader for marko files and a plugin for universal bundling
MIT License
13 stars 4 forks source link

Marko stopped working after upgrade to 5.31.16 #84

Closed xtremespb closed 10 months ago

xtremespb commented 10 months ago

Marko Version: 5.31.16

Details

heretic@1.1.107 /Users/xtreme/Documents/GitHub/heretic ├─┬ @marko/webpack@9.3.4 │ └── marko@5.31.16 deduped └─┬ marko@5.31.16 └─┬ @marko/translator-default@5.31.6 └── marko@5.31.16 deduped

Expected Behavior

Everything was fine on 5.31.14. I expect the same behaviour on 5.31.16 ;-)

Actual Behavior

There is no re-hydration of server code, and the page is empty. The JS events are not triggered (e.g. onMount)

Possible Fix

Currently the only way for me is to downgrade to 5.31.14.

Additional Info ### Your Environment Mac OS Sonoma, MacBook Pro, 32 GB RAM Vivaldi 6.2.3105.58 ### Steps to Reproduce 1. Clone https://github.com/hereticjsorg/heretic.git 2. npm i 3. npm run configure 4. npm run build -- --dev 5. npm run server 6. Go to http://127.0.0.1:3001
DylanPiercey commented 10 months ago

@xtremespb I just cloned this down, followed your steps (but upgraded to marko@31.16 before installing) and the page does appear to show.

Possible there is a cache issue or something on your end? Could you clear ./node_modules/.cache (webpacks cache)?

xtremespb commented 10 months ago

@DylanPiercey, thank you for your investigation. This is a really strange behavior. I realized that the problem is with marko/webpack. Steps to reproduce:

DylanPiercey commented 10 months ago

Between the different installs what is the diff of the lock file?

xtremespb commented 10 months ago
image
DylanPiercey commented 10 months ago

@xtremespb thanks for the report and info.

This was in fact a regression over here. @marko/webpack@9.3.5 has the fix

xtremespb commented 10 months ago

Thank you, it works! 👍