Closed Nikolice closed 1 year ago
This looks like a good idea to me. Would you be so kind as to sign the EasyCLA so we can merge this?
Maybe my commit is incorrect. As I see here and here:
instead of
<a href=contributor.html_url><img src=`${contributor.avatar_url}&s=64` alt=contributor.login loading="lazy"/></a>
should be
<a href=contributor.profile><img src=`${contributor.photo}&s=64` alt=contributor.username loading="lazy"/></a>
UPDATE: No; it seems, that “profile” instead of “html_url” (and “photo” instead of “avatar_url”; and “username” instead of “login”) is only for “https://markojs.com/docs/…” (example), because those pages depend on a specific file. Or it isn't?
Also, instead of
<a href=contributor.html_url><img src=`${contributor.avatar_url}&s=64` alt=contributor.login loading="lazy"/></a>
it can be
<a href=contributor.html_url title=contributor.login><img src=`${contributor.avatar_url}&s=64` alt=contributor.login loading="lazy"/></a>
so, when hovering a picture – a popup with username will show. (The reason is a “title”-attribute with the “contributor.login”-value added, to the <a>
tag.)
Would you be so kind as to sign the EasyCLA … ?
No, I cannot imagine what it is about. Feel free to use my ideas through creating your own commits.
This change looks good, we will merge without EasyCLA.
That's about the Marko's main page Community section. See the details in the comment below!
Please; be careful, – as I have not tested it!