search

marko-knoebl / slides

Presentations for programming courses
Other
374 stars 55 forks source link

add translate javascript-es-2015 to indonesia #6

Open naufaldi opened 3 years ago

naufaldi commented 3 years ago

translate javascript es 2015 to Indonesia. Pls review, because this is first time using rehype-slides. at same time, i will start translate JavaScript: Promises, Fetch and Axios.

Thanks you

marko-knoebl commented 3 years ago

Translation is looking good!

You should also run "npm run build" - then you will get files like "docs/javascript-es-2015-id.html" that contain the actual built presentation.

I noticed that one dependency has changed and will produce a different output in the newest version (lowlight.js) - so if you build you'll get a lot of diffs in the old presentations. You can just ignore those differently built files for now - don't commit them - but you should commit "dist/javascript-es-2015-id*" and "docs/javascript-es-2015-id.html"

naufaldi commented 3 years ago

Thanks you!

oke, will note that. Will add "dist/javascript-es-2015-id" with finishing translation JavaScript: Promises, Fetch and Axios.

marko-knoebl commented 3 years ago

Nice!

But in general you don't worry too much about the build, I can do that too if it's not clear.