marko2276 / ha-unipi-neuron

Custom Home Assistant integration for Unipi devices
MIT License
21 stars 8 forks source link

doesn't work on Core 2024.5 #8

Closed anline380 closed 5 months ago

anline380 commented 6 months ago

Hi Marko, thank you first for the great integration, which has worked wonderfully so far. Unfortunately, it is no longer compatible with Core 2024.5. The lights no longer indicate the correct state, and the binary sensors have completely gone. I had to revert to 2024.4.4 so that the house is not completely dead:( Thanks in advance, Manuel

Geunsjl commented 5 months ago

Okay I did some searching and replacing async_write_ha_state() with schedule_update_ha_state() seems to do the trick. Changed it in binary_sensor.py and light.py. Cover.py already had this for some reason?

anline380 commented 5 months ago

I'll try to use your suggested solution in the next few days (half of my house didn't work after the update). A big thank you for the quick support, Manuel

Geunsjl commented 5 months ago

I am not sure how active the main contributor still is in this github code, but in my logs I see a few alerts a out code that will be deprivated in 2025, so be aware of that...

marko2276 commented 5 months ago

Hi @anline380 and @Geunsjl. Sorry for late response. I am still on an older version of HA and do not update it regularly. I will look into this issue as soon as I find some time (Hopefully by the end of this week).

Regards Marko

marko2276 commented 5 months ago

Hi @anline380 and @Geunsjl. I have made required updates and fixes to work with latest HA core. Please check it out.

Geunsjl commented 5 months ago

@marko2276 I just tested it and it lights/inputs seem to work. I use 2x the XS11 so it complained about the config not being valid (see image). I changed the regex back to the previous one to allow UART in the config.

UNIPI

marko2276 commented 5 months ago

Hi @Geunsjl

Which regex did you change to previous one (as in my commit, I do not recall of changing any regex?. Was it perhaps changed in some older commits? Anyhow, can you please open a formal pull request, so that we can include your fixes?

Regards, Marko

Geunsjl commented 5 months ago

@marko2276 for some reasone I can not find it anymore. Perhaps I changed it on my installation only..?

in binarysensor.py line 32 your regex says r"^[1-3][0-1][0-9]" while mine says r"\w[A-Za-z0-9]" Same goes for light.py line 38 your regex says r"^[1-3][0-1][0-9]|[1-8]" while mine says r"\w[A-Za-z0-9_]"

Not 100% sure mine is correct, but it does allow me to use the UART in/outputs. Probably goes for cover.py as well, but I don't use covers.

I'm not to familiar with using github pull requests so appologies for that. :D

Regards,

Jan-Lennert