search

markocupic / calendar-event-booking-bundle

Contao 4 Extension
13 stars 7 forks source link

AutogenerateBookingForm not compatible with PHP 8 #41

Closed rabauss closed 2 years ago

rabauss commented 2 years ago

Unfortunately the migration AutogenerateBookingForm is not compatible with PHP 8. Argument #2 ($replace) must be of type array|string, null given in https://github.com/markocupic/calendar-event-booking-bundle/blob/7bcd73d403da173f2ee399f16340c074c90ff8d8/src/Migration/AutogenerateBookingForm.php#L129

The error occurs because there has been defined no default for extensions in tl_form_field since Contao 4.9 - see: https://github.com/contao/contao/blob/4.9/core-bundle/src/Resources/contao/dca/tl_form_field.php#L283

markocupic commented 2 years ago

@rabauss Please try https://github.com/markocupic/calendar-event-booking-bundle/tree/5.2.4

rabauss commented 2 years ago

@markocupic: looking good to me!