search

markohlebar / Peckham

Add #import-s from anywhere in the code.
MIT License
714 stars 94 forks source link

General compatibility and multiple bug fixes. #48

Closed clementpadovani closed 9 years ago

markohlebar commented 9 years ago

@ClementPadovani wow thanks! I'll check this tomorrow and make a merge :)

clementpadovani commented 9 years ago

@markohlebar alright! Keep me posted :)

markohlebar commented 9 years ago

Hey @ClementPadovani, it seems that the tests are broken on Peckham target, can you take a peek? I need to put this on Travis.

clementpadovani commented 9 years ago

Alright will do when I get back home.

Thanks, Clément Sent from my iPhone

On Aug 1, 2015, at 1:31 PM, Marko Hlebar notifications@github.com wrote:

Hey @ClementPadovani, it seems that the tests are broken on Peckham target, can you take a peek? I need to put this on Travis.

— Reply to this email directly or view it on GitHub.

clementpadovani commented 9 years ago

Oh yeah @markohlebar, I forgot that I couldn't run the tests because there seems to be some issues with the Kiwi library. There are issues with it overriding the description property and most of all it's using the SenTesting Framework which is deprecated.

Could we chat privately?

clementpadovani commented 9 years ago

@markohlebar I got the tests up and working!

Please check out https://github.com/ClementPadovani/Peckham/commit/b358fd07ff99fe72801669d71bca22cd09234fc2

clementpadovani commented 9 years ago

@markohlebar I got the tests running however they seem to be failing at the moment.

CI Status

https://travis-ci.org/ClementPadovani/Peckham

However they seem to be running fine when I run them from Xcode. I'll check it out.

markohlebar commented 9 years ago

Hey @ClementPadovani I get a cp: 2/MHImportBusterTests/TestFiles/: No such file or directory build error when I'm running tests against Peckham, do you get that?

markohlebar commented 9 years ago

Granted I'm getting that on 7.0 beta 4 (7A165t) which doesn't matter if the build is fine on 6.4

clementpadovani commented 9 years ago

@markohlebar hum weird, I'm running Xcode 7.0 beta too (same build) and I don't get that.

Did you try doing a full clean?

Can you post the build log?