markokajzer / discord-soundbot

A Soundboard Bot for Discord
MIT License
190 stars 69 forks source link

Add shuffle command #107

Closed solar05 closed 2 years ago

solar05 commented 3 years ago

This new command shuffles random sounds in queue, are optional

markokajzer commented 3 years ago

Hey, thank you so much for the contribution!!!

The code is actually looking pretty good, so I'd be fine merging it in. However not sure that a command that just shuffles random stuff into the queue is something anybody would use 😸 I am not using !random myself and I never though that I want to shuffle in multiple random sounds.

Is that something that makes sense for you?

Maybe if a few people from our Discord server upvote this PR, I'd be more confident that the bot needs this functionality.

solar05 commented 3 years ago

Hello! I have a lot of different entries of friends' phrases, but using !combo is inconvenient for me because I need to remember the name of each phrase, and !random command selects only one phrase, so I had an idea to add !shuffle! After shuffling, you sometimes get very funny sentences :)

prenetic commented 3 years ago

This is awesome, I know my friends are going to get a lot of use out of it. Would it make more sense to add this to the existing !random command instead of creating a new command to remember? Just a thought, expanding on what you've already set up with <count> and <tag>.

!random
!random 9
!random 4 loudnoises