markokajzer / discord-soundbot

A Soundboard Bot for Discord
MIT License
190 stars 69 forks source link

Update YouTube downloader and improve stability #147

Closed clairitin closed 2 years ago

clairitin commented 2 years ago

howdy! i made a few changes in my fork (published to docker hub if you'd like to try them out!)

markokajzer commented 2 years ago

Hey thanks for the PR, sooo appreciated. But why did you close it? :'(

I actually did not even know about yt-dlp. I'll look into replacing youtube-dl for good.

If you would like to continue with this (and there really is some good stuff here!), I would like to ask you to

  1. Split up this PR into multiple smaller ones i. There are multiple improvements and touch ups on multiple different parts of the app which I would consider separate from each other
  2. I would decouple any commands from updating dependencies i. While I see how that could be convenient, it a) really does not have anything to do with any particular command b) would lead to the command running longer if the dependency needs updating, and c) can destabilize the command by introducing a whole other category of bugs ii. IMO it should just be a script than you can run on demand to simplify updating of dependencies

If you have any questions, feel free to reach out to me on Discord 👌