search

markolson / chef-ssh

Chef cookbook for managing some mildly-difficult-to-automate SSH configuration
39 stars 54 forks source link

Ubuntu 20.04 and Chef 16 support #76

Open PowerKiKi opened 3 years ago

PowerKiKi commented 3 years ago

Drop umask in known_hosts, because it lead to a fatal error no implicit conversion from nil to integer. And it had actually no purpose because the file always already exist. It either exists before Chef runs, or we create it ourselve via the file resource with proper mode just before using execute.

known_hosts also better detect presence of host in config file for CentOS where ssh-keygen does not print out human readable message including "Host found".

config now supports config file that contains the Include keyword before any Host keyword, as is seen in Ubuntu 20.04.

After merging this, I would suggest to release a 1.0.0, to clearly communicate that this cookbook is production ready and has been used as such for years now.

PowerKiKi commented 3 years ago

Oh, I probably should have mentioned that kitchen test pass.

PowerKiKi commented 3 years ago

@tejaycar, @markolson, are you still active for this project ? Is there a chance you would release this PR ?

If not, would you recommend forking, adding new members to the project, or using an alternative cookbook ?

PowerKiKi commented 2 years ago

@tejaycar, @markolson, could you please either archive this repository, or add new member to continue its maintenance ?

tejaycar commented 2 years ago

@PowerKiKi are you interested in taking over the repository? I'm many years out of the chef community, and in no position to continue maintenance. @markolson more or less handed off to me many years back and has not been very active in the repo for quite some time either.

PowerKiKi commented 2 years ago

@tejaycar, yes I would accept an invitation to join the GitHub project and continue to maintain it in the foreseeable future (but not really add new features).

If I will be mostly the only maintainer, then it would be best if I get admin access, in order to be able setup CI and such. If that's not possible then it might be best to archive this repo and create an "official" fork.

Thank you for getting back to us and happy New year !

tejaycar commented 2 years ago

I'm afraid this is on @markolson . I don't believe I have admin either, so I'm not able to add you to the repo.

PowerKiKi commented 2 years ago

Thank you for your effort. I reached out to Sous-Chefs, to see if they would adopt this cookbook under their organisation. If that doesn't work out, I'll fork the cookbook permanently, either publicly at https://github.com/Ecodev/chef-ssh, or privately, depending on our internal needs...