search

markormesher / android-fab

Floating action button (FAB) for Android with speed-dial menu functionality
Apache License 2.0
211 stars 29 forks source link

Content cover doesn't cover whole screen #35

Closed Yakow13 closed 6 years ago

Yakow13 commented 6 years ago

Device: Samsung SM-T580 Version android-fab: v2.2.2

On the tablet device, the cover keeps the left upper corner uncovered. My guess is, the circle which is used for animation has too small diameter. For more details, see the screenshot.

Thanks for your time :)

screenshot_20180620-163858

markormesher commented 6 years ago

Hi Adam. Thanks for flagging this. I think you're right that the circle is just a bit too small for that screen, and IIRC it's not sized dynamically (obviously something that should be fixed!). I'm on holiday this week but I'll try to take a look over the weekend.

On Wed, 20 Jun 2018, 15:44 Adam Weinzettl, notifications@github.com wrote:

Device: Samsung SM-T580 Version android-fab: v2.2.2

On the tablet device, the cover keeps the left upper corner uncovered. My guess is, the circle which is used for animation has too small diameter. For more details, see the screenshot.

Thanks for your time :)

[image: screenshot_20180620-163858] https://user-images.githubusercontent.com/10089252/41665673-cd426aba-74a8-11e8-9b76-94f78459f454.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/markormesher/android-fab/issues/35, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMi547q5yiGkIkUcb02dotfylVAVUS-ks5t-l-4gaJpZM4UvalM .

Yakow13 commented 6 years ago

Thanks for fast respond Mark.

Awesome :) . I would try it on my own and pull it, but wasn't able compile it in existing project, probably Kotlin vs. Java issue.

markormesher commented 6 years ago

This should be fixed now in v2.3.1