search

markormesher / android-fab

Floating action button (FAB) for Android with speed-dial menu functionality
Apache License 2.0
211 stars 29 forks source link

Simplify the method name #54

Closed naufalprakoso closed 4 years ago

naufalprakoso commented 4 years ago

Hi, I have a suggestion to simplify the method name. Since this library is for Floating Action Button (FAB), I think it's redundant when you define the method name with .set**Button**.....

Here I'm trying to simplify the method name.

markormesher commented 4 years ago

Hey @naufalprakoso, thanks for the contribution! You're right that some of the names get a bit wordy, but there's a reason for it - now and in the future there may be other elements to control, such as the speed-dial items and the content cover, so keeping the names explicit prevents confusion between the elements.

This PR would also be a breaking change for everyone using the library (unless we duplicate the methods and mark the old ones as deprecated, which adds a lot of clutter for not a lot of gain), so I don't think it's worth making the change at this point.

If you're keen to do something else with this library, there are a couple of open issues that might be good first contributions.