search

markormesher / android-fab

Floating action button (FAB) for Android with speed-dial menu functionality
Apache License 2.0
211 stars 29 forks source link

Added new feature button label background color editable #56

Closed theshid closed 4 years ago

theshid commented 4 years ago

Hi @markormesher I added a new feature that lets the user change the color of the button(s) of the menu item, I thought it could be useful. I also added some code in the DemoActivity to showcase the feature.

markormesher commented 4 years ago

Hey @theshid, thanks for the contribution. There is currently a way to change the colour of those buttons - did you run into any problems with that? The current method (see here) allows for a different colour on each item if required, but it looks like this PR would force them all to the same colour. This would also be a breaking change for everyone else using the library.

theshid commented 4 years ago

Oh ok no I didn't encounter any problem with the method I somehow didn't see it. Thanks for pointing out for me. Yes I understand you can discard my PR. sorry about that

markormesher commented 4 years ago

No problem at all, I appreciate you taking an interest and wanting to improve the library!