Closed brookehus closed 5 years ago
cc @thempel
Merging #1388 into devel will decrease coverage by
0.01%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## devel #1388 +/- ##
==========================================
- Coverage 91.55% 91.54% -0.02%
==========================================
Files 225 225
Lines 25450 25454 +4
==========================================
Hits 23302 23302
- Misses 2148 2152 +4
Impacted Files | Coverage Ξ | |
---|---|---|
pyemma/datasets/double_well_thermo.py | 94.25% <88.88%> (-0.93%) |
:arrow_down: |
pyemma/util/statistics.py | 59.4% <0%> (-1%) |
:arrow_down: |
pyemma/coordinates/data/util/traj_info_backends.py | 90.61% <0%> (-0.94%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 9072714...373315a. Read the comment docs.
Should I wait for a test or not? This seems like a minor change, which is not really exposed to user api.
If there should be a test let me know what I should test. I don't mind either way.
LGTM
I decided it was easier to add a parameter to
init
but let me know if you prefer something different. What kind of tests do you want for this?AUTHORS
doc/source/CHANGELOG
(choose any open position to avoid merge conflicts with other PRs). Decide whether your change is a fix or a new feature.