search

markovmodel / PyEMMA

🚂 Python API for Emma's Markov Model Algorithms 🚂
http://pyemma.org
GNU Lesser General Public License v3.0
307 stars 118 forks source link

[msm] split up seperate MSM estimators into individual files #1390

Closed marscher closed 5 years ago

marscher commented 5 years ago

Rationale: The maximumlikelihood module contained a base class, ml, oom and augmented estimators adding up to >2k lines of code, which makes it hard to maintain.

Fixes #1260

codecov[bot] commented 5 years ago

Codecov Report

Merging #1390 into devel will decrease coverage by 0.01%. The diff coverage is 88.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1390      +/-   ##
==========================================
- Coverage   91.55%   91.54%   -0.02%     
==========================================
  Files         225      229       +4     
  Lines       25450    25496      +46     
==========================================
+ Hits        23302    23340      +38     
- Misses       2148     2156       +8
Impacted Files Coverage Δ
pyemma/msm/estimators/_OOM_MSM.py 94.77% <ø> (ø) :arrow_up:
pyemma/msm/estimators/maximum_likelihood_hmsm.py 87.77% <100%> (+0.1%) :arrow_up:
pyemma/msm/estimators/__init__.py 100% <100%> (ø) :arrow_up:
pyemma/msm/__init__.py 100% <100%> (ø) :arrow_up:
pyemma/msm/tests/test_amm.py 95.19% <100%> (+0.02%) :arrow_up:
pyemma/msm/api.py 90.51% <100%> (-0.47%) :arrow_down:
pyemma/msm/tests/test_oom_msm.py 99.73% <100%> (ø) :arrow_up:
pyemma/msm/estimators/augmented_msm.py 83.8% <83.8%> (ø)
pyemma/msm/estimators/oom_reweighted_msm.py 86.95% <86.95%> (ø)
pyemma/msm/estimators/maximum_likelihood_msm.py 92.2% <91.22%> (+3.67%) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9072714...ffa6ea4. Read the comment docs.