markovmodel / PyEMMA

🚂 Python API for Emma's Markov Model Algorithms 🚂
http://pyemma.org
GNU Lesser General Public License v3.0
311 stars 119 forks source link

Is koopman reweighting working with TICA ? #1483

Closed DanielWicz closed 3 years ago

DanielWicz commented 3 years ago

I still/already koopman re-weighting available ? Since, when the TICA's "weights" argument is set to "koopman" (as stated in the documentation http://www.emma-project.org/latest/api/generated/pyemma.coordinates.tica.html) nothing changes.

Here's a code example

tica = pyemma.coordinates.tica(positions_data, lag=10, weigths='koopman')
tica_output = tica.get_output()
tica_concatenated = np.concatenate(tica_output)
print(tica.weights)
print(type(tica.weights))

The output is

None
<class 'NoneType'>
DanielWicz commented 3 years ago

Okay ... the problem was a typo, instead of weigths I wrote weigths and it doesn't trigger an exception. I think