markovmodel / PyEMMA

🚂 Python API for Emma's Markov Model Algorithms 🚂
http://pyemma.org
GNU Lesser General Public License v3.0
307 stars 118 forks source link

solve some syntax warnings #1530

Closed sroet closed 2 years ago

sroet commented 2 years ago

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

Some SyntaxWarning: "is" with a literal. Did you mean "=="? surfaced on downstream tests on the devel branch . This solves them

clonker commented 2 years ago

Thanks alot @sroet :) this was bothering me for a while too but I never got around to fix it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1530 (70bbc9b) into devel (b46e895) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1530      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.02%     
==========================================
  Files         229      229              
  Lines       26833    26833              
==========================================
- Hits        24704    24699       -5     
- Misses       2129     2134       +5     
Impacted Files Coverage Δ
pyemma/coordinates/data/util/reader_utils.py 87.82% <100.00%> (ø)
...emma/_ext/variational/solvers/tests/test_direct.py 88.88% <0.00%> (-8.89%) :arrow_down:
pyemma/util/statistics.py 59.00% <0.00%> (-1.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b46e895...70bbc9b. Read the comment docs.

clonker commented 2 years ago

spurious test failure, merging this.