markovmodel / PyEMMA

🚂 Python API for Emma's Markov Model Algorithms 🚂
http://pyemma.org
GNU Lesser General Public License v3.0
306 stars 119 forks source link

Change ipywidgets version check to use __version__. Fixes #1571. #1573

Closed clonker closed 1 year ago

apayne97 commented 2 years ago

Note that for earlier versions of ipywidgets, __version__ doesn't exist so you may have to be creative with checking

apayne97 commented 2 years ago

Maybe you should do something like:

if getattr(ipywidgets, version_info, False):
    if ipywidgets.version_info[0] < 4:
        raise ImportError()

If the ipywidgets version is stored in __version__ instead, then you know that the version is greater than 4!

apayne97 commented 1 year ago

Woo!

clonker commented 1 year ago

Test failures are unrelated, merging