search

markovmodel / PyEMMA

🚂 Python API for Emma's Markov Model Algorithms 🚂
http://pyemma.org
GNU Lesser General Public License v3.0
306 stars 119 forks source link

Added an optional argument for specifying the tolerance in the class MSM #1579

Closed wehs7661 closed 1 year ago

wehs7661 commented 1 year ago

This PR is aimed to resolve issue #1578.

clonker commented 1 year ago

Thank you! Would you mind moving the new keyword argument to the end of the list? That way this is not a breaking change if people were using the arguments based on their position not with the keyword specifier. I will have to make a deeptime release sometime soon in order for the changes to propagate, I'll see to that next week. :slightly_smiling_face:

wehs7661 commented 1 year ago

That makes sense! I have just made the changes. Thanks!