markovmodel / adaptivemd

A python framework to run adaptive Markov state model (MSM) simulation on HPC resources
GNU Lesser General Public License v2.1
18 stars 7 forks source link

[WIP] Implement trajectories as folders #27

Closed jhprinz closed 7 years ago

jhprinz commented 7 years ago

Almost done. Explanation will come tomorrow...

This also contains all of the other changes as well. We will then have full flexibility in the output files of a simulation

jhprinz commented 7 years ago

Well, this is done.

Trajectories are by default folders now. I have also simplified a lot of the API, so have a look at example notebooks 4 and 5 to see how this works.

This does not add capabilities to work with reduced trajectories, but makes this easy to add.

What is tricky with trajectories is to access a file in the traj folder. You can use

traj.file('myfile')

to get the location of this file, so instead of moving with

bash = 'mv %s %s' % (traj_file, target_file)
# new
bash = 'mv %s %s' % (traj.file('output.dcd')', target.file('traj.dcd'))
jhprinz commented 7 years ago

I checked all examples and it should work better. There are also some little bugfixes for the RPC calls.

jhprinz commented 7 years ago

If there are no objections I would merge this.

franknoe commented 7 years ago

Thanks, that looks good to me. Please go ahead.