search

markovmodel / msmtools

Tools for estimating and analyzing Markov state models
GNU Lesser General Public License v3.0
40 stars 27 forks source link

[ceff-matrix] avoid blowing memory by expanding iterator too early #116

Closed marscher closed 6 years ago

marscher commented 6 years ago

also use faster process pool map_async method. Needed to adopt callback interface to take one argument (chunks finished).

The expansion of the iterator created tons of Python integers (N**2 states).

codecov-io commented 6 years ago

Codecov Report

Merging #116 into devel will decrease coverage by 0.13%. The diff coverage is 60.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #116      +/-   ##
==========================================
- Coverage   89.48%   89.35%   -0.14%     
==========================================
  Files         116      116              
  Lines        9438     9489      +51     
==========================================
+ Hits         8446     8479      +33     
- Misses        992     1010      +18
Impacted Files Coverage Δ
msmtools/estimation/api.py 88.52% <ø> (ø) :arrow_up:
...ls/estimation/tests/test_effective_count_matrix.py 77.27% <26.08%> (-18.25%) :arrow_down:
msmtools/estimation/sparse/effective_counts.py 83.89% <77.08%> (+4.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cc1624...663302d. Read the comment docs.