search

markovmodel / msmtools

Tools for estimating and analyzing Markov state models
GNU Lesser General Public License v3.0
40 stars 26 forks source link

compilation failure windows #32

Closed marscher closed 9 years ago

marscher commented 9 years ago

c:\users\appveyor\appdata\local\temp\1\pip-dijvuv-build\msmtools\estimation\dense\sample_rev.h(28) : fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory

rmcgibbo commented 9 years ago

No c99 with msvc. If you use the c++ compilers instead, even with c ABI, its much better.

franknoe commented 9 years ago

Hmm, gibts vielleicht nicht für den MS VirtualC++ compiler? Ich habe keine Ahnung. Im Prinzip ist das mit den bools nicht wichtig, man kann auch 1 oder 0 ints zurückgeben.

Am 17/07/15 um 17:23 schrieb Martin K. Scherer:

c:\users\appveyor\appdata\local\temp\1\pip-dijvuv-build\msmtools\estimation\dense\sample_rev.h(28) : fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory

— Reply to this email directly or view it on GitHub https://github.com/markovmodel/msmtools/issues/32.

Prof. Dr. Frank Noe Head of Computational Molecular Biology group Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354 Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

marscher commented 9 years ago

@rmcgibbo so you're suggesting to compile all c code with c++ compiler on windows?

rmcgibbo commented 9 years ago

Yep. I'm not sure exactly how to do it though. Renaming the .c files to .cc or .cpp might be enough, not sure. On Jul 17, 2015 8:53 AM, "Martin K. Scherer" notifications@github.com wrote:

@rmcgibbo https://github.com/rmcgibbo so you're suggesting to compile all c code with c++ compiler on windows?

— Reply to this email directly or view it on GitHub https://github.com/markovmodel/msmtools/issues/32#issuecomment-122323090 .

franknoe commented 9 years ago

BTW, welcome to msmtools Robert. This is the package I have mentioned at our last omnia meeting where we could start collecting low-level algos that are useful for both of us. The package name is still preliminary. Please have a look and let us know what you think, and if you see possibilities for joining forces here.

Am 17/07/15 um 17:32 schrieb Robert T. McGibbon:

No c99 with msvc. If you use the c++ compilers instead, even with c ABI, its much better.

— Reply to this email directly or view it on GitHub https://github.com/markovmodel/msmtools/issues/32#issuecomment-122313445.

Prof. Dr. Frank Noe Head of Computational Molecular Biology group Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354 Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

marscher commented 9 years ago

maybe by adding language='c++' to the extension declaration in setup.py. Renaming the units to have '.cpp' suffix does not solve the problem.