[estimation] Bug fix: Check for positivity of c_ij+c_ji when computin…

markovmodel / msmtools

Tools for estimating and analyzing Markov state models

GNU Lesser General Public License v3.0

40 stars 26 forks source link

Closed trendelkampschroer closed 8 years ago

trendelkampschroer commented 8 years ago

…g transition matrix entry p_ij, to prevent NAN-values due to zero-division (0/0).

trendelkampschroer commented 8 years ago

Thanks @fabian-paul for coming up with a quick-fix for this bug. Can you also review and merge?

marscher commented 8 years ago

now we have one version of "fmin" in estimation/dense/util.h and one here. Can we unify this?

trendelkampschroer commented 8 years ago

Oh sorry the fmin-code is obsolete. I'll delete it and update the pull-request.

fabian-paul commented 8 years ago

Except for "fmin", this PR is ok.

trendelkampschroer commented 8 years ago

Removed the obsolete fmin and fmax functions. @fabian-paul or @marscher: Please merge if all is okay.