Closed cwehmeyer closed 5 years ago
I think the last point is covered very briefly in nb01: http://www.emma-project.org/vdevel/generated/01-data-io-and-featurization.html#load-versus-source
But the concept itself although it super useful is not used, since not needed for the small test systems, throughout the notebooks. It is not clear to me whether the reviewer wants to tip finger on this shortage or just wants a single reference.
I think the discretization part would be most useful to demonstrate the feature (eg. performing everything without a single get_output(), load() etc.).
Acknowledgements need to be completed (please check in the future that funding for all authors is there. SFBs must specify the project number).
TH acknowledges financial support from Deutsche Forschungsgemeinschaft (SFB/TRR 186, Project A12). FN and BEH acknowledge funding from European Commission (ERC CoG 772230 "ScaleCell"). FN acknowledges funding from Deutsche Forschungsgemeinschaft (SFB 1114, Projects A04 and C03, NO 825/2-2). SO acknowledges a postdoctoral fellowship from the Alexander von Humboldt Foundation.
I will look at item 3 (citation stuff) either this afternoon or first thing tomorrow morning
@brookehus I did some restructuring of the HMM section in branch details
. Maybe you want togo on with this branch or merge into your branch.
I will PR to your branch!
Item 3 done in #176
Item 5 done by @cwehmeyer by 040c423
Please add as a second affiliation for me:
Rice University, Department of Chemistry, Houston, Texas 77005, United States
@franknoe could you provide a street address?
Online it says 6100 Main St., Houston, TX 77005 for the chem dept
thanks, right
There are several small points to address: