markovmodel / pyemma_tutorials

How to analyze molecular dynamics data with PyEMMA
Creative Commons Attribution 4.0 International
71 stars 34 forks source link

[manuscript] [WIP] simplify HMM section, restructure citations #176

Closed brookehus closed 5 years ago

brookehus commented 5 years ago

Starting this to build off Tim's work already done; not ready to merge.

brookehus commented 5 years ago

In the hmm edits commit, I removed the old/tutorial references from everything except the end of the section, and moved and extended Tim's addition to the discussion.

More coming for other things shortly.

brookehus commented 5 years ago

In the above commit, I flush out some details. I add a reference to the MD tutorial that was just accepted to livecoms, and have posted an issue on their page asking for the best citation. For MEMMs, I reference a section in my JACS perspective; I thought this might be the best solution since there are a ton of citations and it's kind of out of the scope of what we cover.

Please feel free to change/give comments. If there's a part that still needs to be looked at, please direct me to it!

marscher commented 5 years ago

Is this exception caused by plot_1D_histogram_trajectories or is the the brand new matplotlib (3.0.2) version? It says some lines are expected to cross each other.

ValueError: Given lines do not intersect. Please verify that the angles are not equal or differ by 180 degrees.

This is happening during rendering.

Lets see if it happens all of the time.

brookehus commented 5 years ago

This build log file says:

No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11

and then later:

Traceback:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-4-e3efe1547100> in <module>
     15     density=True)
     16 for num, metastable_set in enumerate(pcca.metastable_sets):
---> 17     traj_indices = np.where(np.isin(dtrajs_concatenated, metastable_set))[0]
     18     ax.hist(
     19         observable_traj[traj_indices],

AttributeError: module 'numpy' has no attribute 'isin'

isin was added in numpy 1.13

marscher commented 5 years ago

thanks @brookehus, i've fixed this on master already.

brookehus commented 5 years ago

Now that I've pulled from master it gives the same error you already reported. But interestingly, the top of the log file still says,

No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
marscher commented 5 years ago

https://github.com/conda/conda-build/issues/3170

brookehus commented 5 years ago

@marscher should we merge and deal w/ the other thing separately

marscher commented 5 years ago

what was that latest merge commit good for?

We can treat the matplotlib issue separately.