markovmodel / variational

Basis sets, estimators and solvers for the variational approach of conformation dynamics. NOTE: the code has been merged with PyEMMA and is maintained there.
10 stars 5 forks source link

make discretization self-contained #9

Open franknoe opened 9 years ago

franknoe commented 9 years ago

Currently, the Ramachandran basis set files contain eigenvectors values over phi/psi. The knowledge how the discretization has been made (10 degree bins from -180 to 180) is in the code reading them. This is not good for extensibility because a person that wants to add new parameters now has to back-engineer the code and format their files accordingly.

It would be better to save the discretization / binning information (xbins, ybins) together with the data. In this way, the code is also compatible with data files that use different discretizations.

In order to sort the data into bins, consider using np.digitize.

This issue is not urgent.