search

markpasc / makerbase

A directory of people who make bits and atoms
MIT License
11 stars 1 forks source link

Participation ending in a January doesn't stick #13

Closed apparentlymart closed 12 years ago

apparentlymart commented 12 years ago

When editing a participation, setting the end date to January in any year (as far as I can tell) causes it to be treated as not set at all.

Observed here: http://makerbase.neologasm.org/project/livejournal

Trying to set my participation to end in 2007-01 causes it to be treated as not set at all, but setting it to end in 2007-02 works. Also tried 2006-01 and it too was treated as nothing.

apparentlymart commented 12 years ago

Guess this is just because January is stored as 0 but the template only checks truthiness, not nullitude?

{% if not party.end_month %}
markpasc commented 12 years ago

Ooh, huh. IIRC it's storing months as 0-based so it's probably a truthiness check somewhere.

On Saturday, April 7, 2012 at 12:23 PM, Martin Atkins wrote:

When editing a participation, setting the end date to January in any year (as far as I can tell) causes it to be treated as not set at all.

Observed here: http://makerbase.neologasm.org/project/livejournal

Trying to set my participation to end in 2007-01 causes it to be treated as not set at all, but setting it to end in 2007-02 works. Also tried 2006-01 and it too was treated as nothing.

Reply to this email directly or view it on GitHub: https://github.com/markpasc/makerbase/issues/13

markpasc commented 12 years ago

I fixed that check to look at the year instead and it appears to work. That will still fail if you try to end a participation in year 0 but that's probably okay for now. The fix is on the live site.