markporoshin / dbt-greenplum

Adaptation postgres adapter for Greenplum
36 stars 22 forks source link

upgrade to support dbt-core v1.4.0 #14

Closed dataders closed 1 year ago

dataders commented 1 year ago

Background

The latest version of dbt Core,dbt-core==1.4.0, was published on January 25, 2023 (PyPI | Github). In fact, a patch, dbt-core==1.4.1 (PyPI | Github), was also released on the same day.

How to upgrade

https://github.com/dbt-labs/dbt-core/discussions/6624 is an open discussion with more detailed information. If you have questions, please put them there! https://github.com/dbt-labs/dbt-core/issues/6849 is for keeping track of the community's progress on releasing 1.4.0

The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.4.0 release of your adapter.

the next minor release: 1.5.0

FYI, dbt-core==1.5.0 is expected to be released at the end of April. Please plan on allocating a more effort to upgrade support compared to previous minor versions. Expect to hear more in the middle of April.

At a high-level expect much greater adapter test coverage (a very good thing!), and some likely heaving renaming and restructuring as the API-ification of dbt-core is now well underway. See https://github.com/dbt-labs/dbt-core/milestone/82 for more information.

markporoshin commented 1 year ago

Sure, I'm going to upgrade dbt-greenplum as soon as possible. Hope this week

JackWolverson commented 1 year ago

Hi @markporoshin ive taken a look at this as the version of dbt core being slightly older stopped us from using dbt-utils and caused an issue with where dbt looks for profiles.yml ( only looks in current directory in 1.3+). for supporting 3.11 i think ive done. for the next two tasks i assume as this is mainly an extension of dbt-postgres they are done for free with upgrading the version of core/postgres adaptor. for the add support for more tests im not sure what would need adding or would this be the same as the others where they are done within the postgres adaptor ?

JackWolverson commented 1 year ago

@dataders @markporoshin I have opened a PR please let me know if anything else needs adding for the upgrade to core 1.4

markporoshin commented 1 year ago

@dataders @JackWolverson I've upload new version of dbt-greenplum on pypi https://pypi.org/project/dbt-greenplum/1.4.0/