markqvist / Sideband

LXMF client for Android, Linux and macOS allowing you to communicate with people or LXMF-compatible systems over Reticulum networks using LoRa, Packet Radio, WiFi, I2P, or anything else Reticulum supports.
Other
385 stars 27 forks source link

Keyboard suggestions don't seem to work on message input #40

Closed neutralinsomniac closed 8 months ago

neutralinsomniac commented 10 months ago

I looked into this a bit and this seems possibly related to a change in kivy's TextInput widget: "Changed in version 2.1.0: keyboard_suggestions is now inherited from FocusBehavior."

I notice that you're using KivyMD, so I looked into how they handle FocusBehavior but I see no mention of the keyboard_suggestions property there, and I'm having a heck of a time getting my attempted patched version of Sideband to run on MacOS to test it (it just pretends to start then immediately exits).

markqvist commented 10 months ago

Please see this PR and this commit for reference.

It's a pretty annoying bug, and the fix is not so trivial it seems, since setting those parameters then causes the bug that was fixed in https://github.com/markqvist/Sideband/commit/d87058517813a175282326e8456eb70c62394e94.

markqvist commented 10 months ago

If anyone can figure out a method that fixes both, it would be pretty great :)