markrai / fontcompare

an easy way to dynamically compare locally hosted fonts
MIT License
21 stars 3 forks source link

[Features proposal] Self hosted font collection #2

Open oleole39 opened 1 week ago

oleole39 commented 1 week ago

Hello, thanks, that's an interesting tool!

Could we imagine in addition to the ability to open fonts on the client side a way to manage a self-hosted fonts collection as an alternative to websites such as https://www.1001fonts.com or https://www.fontsquirrel.com ?

markrai commented 17 hours ago

@oleole39 - I just separated out the monolith index.html to its separate parts. A step in the direction to expand it :)

I added some additional features, and took care not to break any of your functionality.

Please take a second look when you get a chance, in case, I missed anything, although it seems to work well.

oleole39 commented 10 hours ago

@oleole39 - I just separated out the monolith index.html to its separate parts. A step in the direction to expand it :)

Good move!

Please take a second look when you get a chance, in case, I missed anything

Everything looks functional to me as well for those features (I've just opened a distinct issue for questions about color pickers)! But If we wanna go in the details, I notice that css property margin: 0 10px; got added for label[for="fontSize"]. As a matter of personal taste I find it a bit surprising (I'd rather have the figure closer to the unit select box so that they look grouped) but that's no big deal... Whatever the design choice, I would nevertheless advocate against using 2 properties (width + margin) working on the same thing without apparent necessity - you may only change the width size to a higher value (noting that it should be at least 3ch, i.e. 3-figure long to avoid UX scrambling when zooming from 1-digit figure to 3-digit figure), and leave margin to its default value (0).