search

markrai / fontcompare

an easy way to dynamically compare locally hosted fonts
MIT License
29 stars 3 forks source link

[Bug] Color picker and mouse right click #8

Open oleole39 opened 3 days ago

oleole39 commented 3 days ago

Hello! Color picker addition is great, but I wonder about potential bugs:

  1. Is triggering the background color one with the right click of the mouse the intended behavior (as opposed to the fact that the JS code mentions shiftKey)? EDIT: actually if I press shift while right-clicking I see the usual right-click context menu - maybe you wanted the opposite ?
  2. in addition to triggering the picker when right-clicking on the page, I see the background color square moving where the right-click was made (and remain there afterward). Was that made having in mind a specific use or is that more of a bug ?
  3. Somehow strange out of consistency that there seems to be no keyboard/mouse shortcut for the font color picker.
markrai commented 3 days ago

1 & 2: whoops! That is a "left-over"from a previous implementation. I've removed the listener. Thank you for catching that!

3: Hmm.. That's a good idea. I'm going to give it some thought as to what the best way to implement this might be. Maybe we can do it so that clicking on the "font" would open the color-picker for the fonts, and clicking on the background will open the color-picker for the background...