Internet Explorer 8 throws "Expected identifier" when loading

markrcote / flot-axislabels

Axis Labels Plugin for Flot. This repo is unmaintained in part due to flot being in a similar situation.

95 stars 71 forks source link

Internet Explorer 8 throws "Expected identifier" when loading #16

Closed gkasparek closed 10 years ago

gkasparek commented 11 years ago

Have you tested this in IE8 and is it expected to work? I get "Expected identifier" error. I think this is releated to the use of "delete" which maybe is reserved in IE8. I replaced .delete with .dodelete in 3 places and it seems to load fine after that.

markrcote commented 10 years ago

I did test this originally in IE 8, though it is possible that something broke in the mean time. I don't have IE 8 handy, though, but I'll try to get a hold of it.

markrcote commented 10 years ago

You are very right! I can't find a good explanation for why this happens, but it's fixed now. Sorry for the delay!

gkasparek commented 10 years ago

Thanks Mark!

On Sun, Jan 5, 2014 at 5:32 PM, Mark Côté notifications@github.com wrote:

Closed #16 https://github.com/markrcote/flot-axislabels/issues/16.

— Reply to this email directly or view it on GitHubhttps://github.com/markrcote/flot-axislabels/issues/16 .

Gil Kasparek gil@allnight.com