Closed Smoren closed 1 year ago
Totals | |
---|---|
Change from base Build 3924811668: | 0.005% |
Covered Lines: | 306 |
Relevant Lines: | 307 |
Hi @markrogoyski
I've resolved confilicts and added descriptions for side effect terminal operations to the READE file.
I've rebased this branch from develop
.
Hi @Smoren,
Thank you for the suggestion. I took a different approach to implementing this.
In this commit I add Reduce::toString()
with not only an optional separator (glue) but also optional prefix and suffix: https://github.com/markrogoyski/itertools-php/commit/471c59bce5b9fc31e5db93c5966032977c0f1c22
In this commit I add these options to Stream::print
as well: https://github.com/markrogoyski/itertools-php/commit/b335c45071b96983ecf572c679182b9646e4bcd0
Thanks again for the feature suggestion. Mark
OK. Good idea. Thank you for this functionality!
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 3921770479: | 0.02% |
Covered Lines: | 299 |
Relevant Lines: | 302 |
Stream::print()
:$glue
param added.I think there is a common task to print collections with glue (e. g.
,
).Since this branch starts from
single_chunkwise
this PR makes sense to merge after the merge of previous PR.Sorry for this confusion.