Closed Smoren closed 1 year ago
Hi @markrogoyski,
Have you already seen this issue? I think this needs to be fixed before the next release.
Hi @Smoren,
Sure, if you think it is unnecessary. I went ahead and removed it.
Thank you @markrogoyski,
I saw your commit, but this line is repeated several times for defferent methods in README. I think we need to remove them all.
Hi @Smoren,
Thanks for the heads up. I removed another one. Let me know if I missed any other comments.
Thanks.
Hi @markrogoyski,
Thank you, I think everything is OK now!
https://github.com/markrogoyski/itertools-php/blob/e13f5be9ae94ce042af5c122d70429d0027ff38e/README.md?plain=1#L961
Do we realy need this clarification?
Look at all the points:
$minIntersectionCount
is 1, then multiset union rules apply.$minIntersectionCount = 1
and multisets on input, then we still have case (1).$minIntersectionCount = 1
and common sets on input, then no multisets rules needed.So i think the case (2) is redundant.