README fix about multiset rules

Smoren commented 1 year ago

Do we realy need this clarification?

Look at all the points:

If input iterables produce duplicate items, then multiset intersection rules apply.
If $minIntersectionCount is 1, then multiset union rules apply.

So if we have multisets on input then we have the case (1).
When we have $minIntersectionCount = 1 and multisets on input, then we still have case (1).
And when we have $minIntersectionCount = 1 and common sets on input, then no multisets rules needed.

So i think the case (2) is redundant.

Smoren commented 1 year ago

Hi @markrogoyski,

Have you already seen this issue? I think this needs to be fixed before the next release.

markrogoyski commented 1 year ago

Hi @Smoren,

Sure, if you think it is unnecessary. I went ahead and removed it.

Smoren commented 1 year ago

Thank you @markrogoyski,

I saw your commit, but this line is repeated several times for defferent methods in README. I think we need to remove them all.

markrogoyski commented 1 year ago

Hi @Smoren,

Thanks for the heads up. I removed another one. Let me know if I missed any other comments.

Thanks.

Smoren commented 1 year ago

Hi @markrogoyski,

Thank you, I think everything is OK now!

markrogoyski / itertools-php