`Single::compressAssociative()` method has been improved

Smoren commented 1 year ago

Hi @markrogoyski,

I've improved Single::compressAssociative() method with more quick separate logic for arrays and ArrayAccess instances.

Now this method gets values from iterable by keys using [] operator when it can.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4171562197

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 99.855%

Totals
Change from base Build 4171111633:	0.002%
Covered Lines:	687
Relevant Lines:	688

💛 - Coveralls

Smoren commented 1 year ago

This branch is rebase from develop.

Smoren commented 1 year ago

I've rebase this branch from develop again.

Smoren commented 1 year ago

Hi @markrogoyski

Thank you for this note. I didn't know that Arrayiterator implements ArrayAccess. I removed the extra fixture and replaced its use with ArrayIterator.

markrogoyski / itertools-php