`Summary::isEmpty()` method added

Smoren commented 1 year ago

Hi @markrogoyski,

I've added new methods and covered them by tests:

Summary::isEmpty()
Stream::isEmpty()

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4351704604

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.867%

Totals
Change from base Build 4350957471:	0.001%
Covered Lines:	752
Relevant Lines:	753

💛 - Coveralls

markrogoyski commented 1 year ago

LGTM. Just a comment about some additional test cases that clarify what empty really means.

Smoren commented 1 year ago

Thank you @markrogoyski,

I've added the new test cases you suggested.

markrogoyski / itertools-php