Added instructions for Linux install to README

markshust / docker-magento

Mark Shust's Docker Configuration for Magento

https://m.academy/courses/set-up-magento-2-development-environment-docker/

MIT License

2.54k stars 997 forks source link

Added instructions for Linux install to README #1050

Closed kmilodenisglez closed 6 months ago

kmilodenisglez commented 8 months ago

added some dependencies that were needed to be able to run magento-docker successfully on a VPS with Debian GNU/Linux 12

what-the-diff[bot] commented 8 months ago

PR Summary

Enhancement of Linux Installation Instructions The PR includes a valuable update that adds instructions to install the necessary dependencies specifically on Linux systems.
Revamped Docker Guide for Linux The directions for running Docker on Linux have been updated to include the necessity of certain post installation commands and the installation of Docker Compose, making it more comprehensive for Linux users.
Comparison with Docker Desktop It was noted in this PR that, unlike with Docker Desktop (which is a comprehensive desktop application), the Linux installation requires manual setup of these steps.
Magento Installation Guidance Lastly, the PR also adds a reminder for users to copy compose.dev-linux.yaml to compose.dev.yaml before installing Magento. This step is vital to ensure a successful installation of Magento.

kmilodenisglez commented 8 months ago

Updated the README.md with some dependencies that needed to be installed on a VPS with Debian GNU/Linux 12 installed.

Dependencies:

curl
libnss3-tools
unzip
rsync
bc

markshust commented 7 months ago

Thanks for the PR. I think it would make sense to move this to the Linux section at https://github.com/markshust/docker-magento#linux instead?

Also, there is only one item here so I don't think there is a need for a 1. bullet point.

kmilodenisglez commented 7 months ago

Thanks for the PR. I think it would make sense to move this to the Linux section at https://github.com/markshust/docker-magento#linux instead?

Also, there is only one item here so I don't think there is a need for a 1. bullet point.

yes you're right

kmilodenisglez commented 7 months ago

@markshust I just modified the readme.md of this same PR, check it and tell me.

markshust commented 7 months ago

@kmilodenisglez for some reason I cannot make changes to this PR myself, so can you make a couple more updates?

Move the block that added to just before the #### The host.docker.internal hostname line. The lines that followed your previous line block are basic lines about running Docker on Linux, and should come first.
Add a description after your heading to remain consistent with the rest of the documentation. It can say something like "docker-magento requires a few system dependencies to be installed on Linux in order to function properly. Please execute the following line from terminal to install these dependencies:"

kmilodenisglez commented 6 months ago

@kmilodenisglez for some reason I cannot make changes to this PR myself, so can you make a couple more updates?

Move the block that added to just before the #### The host.docker.internal hostname line. The lines that followed your previous line block are basic lines about running Docker on Linux, and should come first.

Add a description after your heading to remain consistent with the rest of the documentation. It can say something like "docker-magento requires a few system dependencies to be installed on Linux in order to function properly. Please execute the following line from terminal to install these dependencies:"

I already updated the readme