markshust / docker-magento

Mark Shust's Docker Configuration for Magento
https://m.academy/courses/set-up-magento-2-development-environment-docker/
MIT License
2.54k stars 997 forks source link

bin/log command added #1060

Closed bbakalov closed 7 months ago

bbakalov commented 7 months ago

It's the new command bin/log that tail logs from the Magento var/log folder all and specific logs.

Usage: bin/log __

Arguments: specific_log_files If specific_log_files are NOT provided, show all logs. Example:

bin/log system.log cache.log

Options: -h, --help Display help message

what-the-diff[bot] commented 7 months ago

PR Summary

YevhenZvieriev commented 7 months ago

Hi, @bbakalov

Check this PR Added script for log viewer

bbakalov commented 7 months ago

Hi, @bbakalov

Check this PR Added script for log viewer

Hello @YevhenZvieriev your work looks cool. But I think it is also good to somehow combine your approach and mine. As I see it, in your log viewer, there is no possibility to tail logs in real time.

YevhenZvieriev commented 7 months ago

@bbakalov I added the possibility to tail logs in real-time in this commit

bbakalov commented 7 months ago

@bbakalov I added the possibility to tail logs in real-time in this commit

Jesus) you are the best) Waiting while your code will be merge.

You made a good job. Thx)

markshust commented 7 months ago

Hey all,

I reviewed both PRs and I actually like this one a lot better. It's much simpler, and it "just works" as I would expect it to work. I ran bin/log and the logs were immediately outputted. Then tested with --help and then bin/log system.log, and it just worked... immediately.

I see no reason to not move forward with this script. I appreciate both of your efforts and hate to choose between two nicely-written PRs, but I think this one wins out for it's simplicity and lack of UI -- it's more intuitive.