markshust / docker-magento

Mark Shust's Docker Configuration for Magento
https://m.academy/courses/set-up-magento-2-development-environment-docker/
MIT License
2.58k stars 1.01k forks source link

Multi domain ssl support #1173

Closed YevhenZvieriev closed 5 months ago

YevhenZvieriev commented 5 months ago

Overview

This PR enhances the setup-ssl script to support generating SSL certificates for multiple domains. Previously, the script only handled a single domain according to #1172, which limited its utility for multi-domain setups.

Changes

Testing

  1. Run the script with multiple domains:
   bin/setup-ssl magento.test foo.test
  1. Verify that SSL certificates are created and moved to /etc/nginx/certs/ for each domain.

  2. Ensure the Nginx containers restart successfully and apply the new configurations.

This enhancement simplifies the setup process for projects requiring SSL for multiple domains, improving developer productivity and ensuring secure connections across all specified domains.

Before :

Screenshot from 2024-06-10 22-16-42

After:

Screenshot from 2024-06-10 22-18-40

what-the-diff[bot] commented 5 months ago

PR Summary

YevhenZvieriev commented 5 months ago

Closing in because this PR does not resolve issue #1172, with generating SSL certs for more than one domain.

Resolving was reverting back to an old commit for the bin/setup-ssl script, see comment https://github.com/markshust/docker-magento/issues/1172#issuecomment-2166205432 .

So, this commit causes the #1172 issue.

ssx commented 3 months ago

This is fixed in https://github.com/markshust/docker-magento/issues/1172