Closed YevhenZvieriev closed 5 months ago
Introduction of Multi-Domain Certificate Generation The process of creating digital certificates has been improved. Now, it's possible to automatically generate certificates for more than one domain at a time, making the task more efficient and less time-consuming.
Implementation of Successful Generation Check A new check has been added to confirm whether the generation of certificates is successful. This means we are now able to identify and rectify any issues immediately. This enhances the reliability of the certificates we produce and the overall security of our operations.
Relocation of Key and Certificate Files Upon successful creation, key and certificate files have now been set to automatically move to a specified location ('/etc/nginx/certs/'). This ensures all important files are kept in a single, secure location, easy to manage and access when needed. This improvement enhances organization and aids in maintaining our system effectively.
Closing in because this PR does not resolve issue #1172, with generating SSL certs for more than one domain.
Resolving was reverting back to an old commit for the bin/setup-ssl
script, see comment https://github.com/markshust/docker-magento/issues/1172#issuecomment-2166205432 .
So, this commit causes the #1172 issue.
This is fixed in https://github.com/markshust/docker-magento/issues/1172
Overview
This PR enhances the
setup-ssl
script to support generating SSL certificates for multiple domains. Previously, the script only handled a single domain according to #1172, which limited its utility for multi-domain setups.Changes
Testing
Verify that SSL certificates are created and moved to /etc/nginx/certs/ for each domain.
Ensure the Nginx containers restart successfully and apply the new configurations.
This enhancement simplifies the setup process for projects requiring SSL for multiple domains, improving developer productivity and ensuring secure connections across all specified domains.
Before :
After: