markshust / docker-magento

Mark Shust's Docker Configuration for Magento
https://m.academy/courses/set-up-magento-2-development-environment-docker/
MIT License
2.53k stars 997 forks source link

Multiple domain setup with magento docker setup #655

Closed malikabid closed 2 years ago

malikabid commented 2 years ago

Description

  1. I have setup magento 2.4 with the markshust/docker-magento and it is working fine.
  2. Now my setup is multi-website with different domains (e.g. https://ukwebsite.local and https://usawebsite.local)
  3. How can I setup this?
markshust commented 2 years ago

Hi @malikabid, have you seen this lesson? https://courses.m.academy/courses/487758/lectures/14780970

This should document how to accomplish this. If you are still having trouble after follow the steps in this lesson, please let me know and I can re-open this ticket.

malikabid commented 2 years ago

Hi @markshust Thank you for the reference. I did a little differently - I added the following line to the docker-compose.dev.yml file - ./src/nginx.default.conf:/etc/nginx/conf.d/default.conf:cached instead of adding a new Dockerfile.

This and add the Nginx configuration in the file.

The rest of the steps are the same.

Will it have any bad/good impact overall?

markshust commented 2 years ago

That method is totally ok 👍 No performance implications, since it's just use in the Nginx config.